Conversation
|
This proved to require an odd and detailed intervention. Assuming the efforts in #2747 are accepted, I think this PR can be closed |
I like the simplicity of this fix, but how do we know if it works? Should we merge and see what happens? |
|
Yes, it will need merging to verify if it works . |
|
Can technically swap over to target |
|
Can we get this merged now? The failing labeler is causing CI checks to fail on all PRs. |
|
Sure, it just needs a maintainer to review/approve/merge. |
|
@d-v-b , will auto-merge happen if the labeler run fails? (as it will, since it won't take action until its in main) |
I was wondering the same thing. we shall see! |
|
Looks like this worked: https://github.com/zarr-developers/zarr-python/actions/runs/12951743813/job/36127460117?pr=2714 🎉 |
This seems to have gone wrong in #2736, so trying to fix here.
Because the job is defined using
pull_request_target, it's run from the GH actions config on themainbranch, so this will need merging to fix the job.